Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(iOS): new architecture props #983

Merged
merged 1 commit into from
Dec 2, 2024
Merged

fix(iOS): new architecture props #983

merged 1 commit into from
Dec 2, 2024

Conversation

newer97
Copy link
Contributor

@newer97 newer97 commented Dec 1, 2024

Overview

When using the new Architecture in iOS some of the props like themeVariant, shouldOpenOnLongPress and hitSlop are not handled correctly.

Before After
Screenshot 2024-12-01 at 14 05 20 Screenshot 2024-12-01 at 14 07 49

Test Plan

  • validated that all props are passed correctly when using the new architecture.

@newer97 newer97 requested a review from Naturalclar as a code owner December 1, 2024 11:59
Naturalclar
Naturalclar approved these changes Dec 1, 2024
View reviewed changes
Copy link
Member

@Naturalclar Naturalclar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@Naturalclar Naturalclar merged commit b900efc into react-native-menu:master Dec 2, 2024
5 checks passed
@JacksonML JacksonML mentioned this pull request Dec 2, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Naturalclar Naturalclar Naturalclar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@newer97 @Naturalclar